Repository navigation
fix(editor): separate plate grids from their metadata and retire covered suggestions - #11
Merged
Merged
Conversation
The scan merged a 96-well plate map with the sample metadata columns beside it into one seventeen-column table, stretched tables through rows of N/A filler, and read the A..H row labels as list fields. - A header run split by a spacer column now stays apart when the columns repeat (a grid copies whole columns, a record table does not) or when a numbered axis such as 1..12 sits beside labelled columns. - Rows of placeholder filler no longer extend a table block, and a header row of placeholders is not a table at all. - Numeric record names count for a transposed table, so a plate grid reads as one matrix table whose records are the plate columns. - A single letter heading a run of single letters is a grid axis, not a list field. - `dropSuggestionsCoveredBy` retires the suggestions a field already answers.
Saving a field by drawing a selection left the suggestion card that proposed the same region in the sidebar, so the list disagreed with the schema. Saving now drops every suggestion the new field covers, which is what pressing Accept already did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
The scan proposed one table spanning a plate map and the sample metadata columns beside it, stretched through rows of
N/Afiller, and a field saved over a suggested range left its suggestion card in the sidebar.Special things to note
1..12) and the row letters (A..H) name the values. One row per well would need a different field shape.Change outline
The scan builds candidates per sheet, then dedupes, suppresses overlaps and ranks them. Three new guards sit inside that pipeline, and one sits where a field is saved.
The two shape rules, as pseudocode:
Saving a field now prunes the list, so drawing a selection and pressing Accept end in the same state:
editor/src/ ├── App.tsx # retires suggestions a saved field covers └── lib/ ├── suggestions.ts # grid, placeholder and axis guards, plus dropSuggestionsCoveredBy └── suggestions.test.ts # 9 new cases, including the reported plate-layout workbook