Sign phar when releasing it #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
=========================================
Coverage 94.90% 94.90%
Complexity 605 605
=========================================
Files 69 69
Lines 1609 1609
=========================================
Hits 1527 1527
Misses 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
micheleorselli
changed the title
micheleorselli
commented
Mar 20, 2025
| tools: composer:v2.2 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.TOKEN_GITHUB }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Member
Author
There was a problem hiding this comment.
not strictly related to the scope of this PR but reading this doc it seems the default token is enough. I haven't removed the TOKEN_GITHUB for now, let's see if we face problems
micheleorselli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address what is reported on #460