Skip to content

Sign phar when releasing it #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micheleorselli merged 3 commits into from
Mar 20, 2025
Merged

Sign phar when releasing it #465

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a3efda
adds steps to sign phar when releasinng it
micheleorselli Mar 18, 2025
9806ce6
uses default GITHUB_TOKEN
micheleorselli Mar 20, 2025
172ac8b
fix
micheleorselli Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
php-version: ${{ matrix.php-versions }}
tools: composer:v2.2
env:
GITHUB_TOKEN: ${{ secrets.TOKEN_GITHUB }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

@micheleorselli micheleorselli Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly related to the scope of this PR but reading this doc it seems the default token is enough. I haven't removed the TOKEN_GITHUB for now, let's see if we face problems


- name: Validate composer.json and composer.lock
run: composer validate
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
php-version: 7.4
tools: composer:v2.2
env:
GITHUB_TOKEN: ${{ secrets.TOKEN_GITHUB }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Install dependencies
run: composer install --prefer-dist --no-dev -o
Expand All @@ -84,7 +84,7 @@ jobs:

- name: "Rename phar to avoid conflicts"
run: mv ./phparkitect.phar phparkitect-${{ github.sha }}.phar

- name: "Upload phar file artifact"
uses: actions/upload-artifact@v4
with:
Expand All @@ -104,7 +104,7 @@ jobs:
with:
php-version: ${{ matrix.php-versions }}
env:
GITHUB_TOKEN: ${{ secrets.TOKEN_GITHUB }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: "Download phar ./phparkitect-${{ github.sha }}.phar"
uses: actions/download-artifact@v4
Expand All @@ -119,20 +119,41 @@ jobs:
needs: [build, smoke-test-phar]
runs-on: "ubuntu-22.04"
if: github.event_name == 'release'
permissions:
contents: write
steps:
- name: "Download phar ./phparkitect-${{ github.sha }}.phar"
uses: actions/download-artifact@v4
with:
# will download phar in project root
name: phar-artifact

- name: Upload Release Asset
uses: svenstaro/upload-release-action@v2

- name: Import GPG key
uses: crazy-max/ghaction-import-gpg@v6
with:
gpg_private_key: ${{ secrets.GPG_KEY_47CD54B6398FE21B3709D0A4D9C905CED1932CA2 }}
passphrase: ${{ secrets.GPG_KEY_47CD54B6398FE21B3709D0A4D9C905CED1932CA2_PASSPHRASE }}

- name: Rename phar
run: mv ./phparkitect-${{ github.sha }}.phar phparkitect.phar

- name: Sign the PHAR
run: |
gpg --local-user 47CD54B6398FE21B3709D0A4D9C905CED1932CA2 \
--batch \
--yes \
--passphrase="${{ secrets.GPG_KEY_47CD54B6398FE21B3709D0A4D9C905CED1932CA2_PASSPHRASE }}" \
--detach-sign \
--output ./phparkitect.phar.asc \
./phparkitect.phar

- name: Add phar to the release
uses: softprops/action-gh-release@v2
with:
repo_token: ${{ secrets.GITHUB_TOKEN }}
file: ./phparkitect-${{ github.sha }}.phar
asset_name: phparkitect.phar
tag: ${{ github.ref }}
token: ${{ secrets.GITHUB_TOKEN }}
files: |
phparkitect.phar
phparkitect.phar.asc

publish_docker_images:
needs: [build, smoke-test-phar]
Expand Down