Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.11.2 falsely detecting start/end time changed (by number of hours offset from UTC) #2047

Open
phw198 opened this issue Jan 19, 2025 · 10 comments
Assignees
Labels
bug Something's not working right high resolved Working hotfix available timezones
Milestone

Comments

@phw198
Copy link
Owner

phw198 commented Jan 19, 2025

OGCS Version: v2.11.2

Bug Description
OGCS incorrectly detects changes in start and end times for Google events, due to comparisons in UTC not localtime.

Steps to Reproduce the Issue
Full or delta syncs report a change in start and/or end time when there is none. The difference in time is the offset between localtime and UTC.

@phw198 phw198 added the bug Something's not working right label Jan 19, 2025
@phw198 phw198 self-assigned this Jan 19, 2025
@phw198
Copy link
Owner Author

phw198 commented Jan 19, 2025

📦 This should now be resolved with hotfix v2.11.2.1.zip (see instructions for applying).
      CRCs: Zip = F6A3BA15 Exe = 8197E679

Please let me know how it goes, if you apply the hotfix.

@phw198 phw198 added the waiting fix confirmation Hotfix available for testing label Jan 19, 2025
@TheJacksonian
Copy link

TheJacksonian commented Jan 20, 2025

I know I'm not the original reporter, but I too had this issue on 2 recurring meetings and 2 seperate meetings I'd added after moving to the new Aplha.
The hotfix has resolved the issue for me. The meetings have returned to their correct time.

@timothy-holmes
Copy link

I can also confirm hotfix resolved this issue. Needed to do a full sync to revert to the correct times.

@jrhalasz
Copy link

The hotfix resolved the issue after a full sync.

@lemonbutter
Copy link

I have an additional problem described here: #1978 (comment)
Even after the full sync, I still get these offset errors.
Also I think the time shift is sometimes still wrong. But have to check that again tomorrow. Will add more information, if it's really still wrong.

@emotionstudy4
Copy link

The hotfix corrected the bug for me. Thanks for all your hard work!

@phw198 phw198 added resolved Working hotfix available and removed waiting fix confirmation Hotfix available for testing labels Jan 23, 2025
@phw198 phw198 added this to the v2.11.3 milestone Jan 23, 2025
@phw198
Copy link
Owner Author

phw198 commented Jan 23, 2025

Thanks everyone for confirming the fix 👍🏻

As this is a high impact bug, I've quietly patched the ZIP and setup.exe on v2.11.2.0 for new installers; unfortunately upgraders will have to apply the hotfix on this page.

@lemonbutter we'll track your issue over on #1978, as it predates the bug that caused the problem on this issue.

@joedotbloggs
Copy link

Hi, this has fixed the problem when viewing items in the calendar that are synced from google cal to outlook cal.
The entries are now at the correct time - so amazing and Thankyou!

But there may still bepart of the bug not fixed - ie. in the csv's produced and in the OGCS sync verbose output, the timestamp on the text displayed/logged is still incorrect.
It seems to be not respecting the timezone offset - eg. in the outlook_create.csv, the "starttime" and "Endtime" shows eg. "5/02/2025 6:50:00 AM +00:00" which maybe in my example should really likely read as something like "5/02/2025 6:50:00 AM +08:00"?
And the sync log shows "And the OGCS app sync log tab (with verbose logging ticked) shows "5/02/2025 6:50:00 AM " but should show "5/02/2025 2:50:00 PM ".

@phw198
Copy link
Owner Author

phw198 commented Feb 6, 2025

@joedotbloggs You are indeed correct and I had already coded a fix, but just not built a hotfix for it as no one had spotted it yet!

📦 If you would like to confirm hotfix v2.11.2.6.zip does indeed resolve it, it would appreciated though (see instructions for applying).
      CRCs: Zip = 7BFFA637 Exe = 6A844883

phw198 added a commit that referenced this issue Feb 6, 2025
Log (R1) for series occurrence calendar item summary.
#2047
@phw198 phw198 pinned this issue Feb 6, 2025
@joedotbloggs
Copy link

joedotbloggs commented Feb 7, 2025

📦 If you would like to confirm hotfix v2.11.2.6.zip does indeed resolve it, it would appreciated though (see instructions for applying).       CRCs: Zip = 7BFFA637 Exe = 6A844883

This hotfix (2.11.2.6) works - fixes both the CSV's and the Verbose Log!
Thank you :)

@phw198 phw198 marked this as a duplicate of #2065 Feb 8, 2025
@phw198 phw198 marked this as a duplicate of #2069 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working right high resolved Working hotfix available timezones
Projects
None yet
Development

No branches or pull requests

7 participants