Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GBK charset description #8101

Merged
merged 35 commits into from
Jan 12, 2022
Merged

Add GBK charset description #8101

merged 35 commits into from
Jan 12, 2022

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 31, 2021 •
edited by ethercflow
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add GBK charset description.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@zimulala zimulala added the v5.4 This PR/issue applies to TiDB v5.4. label Dec 31, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 31, 2021 09:57
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2021
@TomShawn TomShawn requested a review from qiancai December 31, 2021 09:58
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 31, 2021
@TomShawn
Copy link
Contributor

@zimulala Please involve a technical review and a PM review. Thanks!

@zimulala
Copy link
Contributor Author

zimulala commented Jan 4, 2022

PTAL @tangenta @xiongjiwei

TomShawn
TomShawn reviewed Jan 4, 2022
View reviewed changes
character-set-gbk.md Outdated

### 非法字符兼容性

* 在设置成 `character_set_client = gbk`、`character_set_connection = utf8mb4` 和 `character_set_table = gbk` 的情况下，TiDB 处理非法字符的情况与 MySQL 兼容。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个都是 MySQL 的配置项吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是，MySQL 的系统变量

tangenta
tangenta reviewed Jan 5, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Jan 5, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

zimulala commented Jan 5, 2022

PTAL @tangenta

xiongjiwei
xiongjiwei reviewed Jan 5, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
character-set-gbk.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jan 6, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jan 6, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
zimulala and others added 2 commits January 12, 2022 14:19
shichun-0415
shichun-0415 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 12, 2022
qiancai
qiancai reviewed Jan 12, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Jan 12, 2022
View reviewed changes
character-set-gbk.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented Jan 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b9c1ad5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@ti-chi-bot ti-chi-bot merged commit 38d8c88 into pingcap:master Jan 12, 2022
@qiancai qiancai mentioned this pull request Jan 17, 2022
Merged
15 tasks
@zimulala zimulala deleted the zimuxia/gbk branch January 17, 2022 06:56
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 18, 2022
@lilin90 lilin90 mentioned this pull request Jul 8, 2024
Merged
17 tasks
This was referenced Jul 8, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@TomShawn TomShawn TomShawn left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@tangenta tangenta tangenta approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees

@qiancai qiancai

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zimulala @ti-chi-bot @TomShawn @easonn7 @qiancai @xiongjiwei @tangenta @shichun-0415