Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv-config-file: update the default value of use-unified-pool #4707

Merged
merged 1 commit into from
Jan 25, 2021
Merged

tikv-config-file: update the default value of use-unified-pool #4707

merged 1 commit into from
Jan 25, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jan 25, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Update the default value of use-unified-pool from false to true.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn requested a review from sticnarf January 25, 2021 09:25
@TomShawn TomShawn self-assigned this Jan 25, 2021
@TomShawn TomShawn added needs-cherry-pick-5.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR's assignee is translating this PR. labels Jan 25, 2021
sticnarf
sticnarf approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@sticnarf, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@TomShawn TomShawn merged commit 4ad2781 into pingcap:master Jan 25, 2021
@TomShawn TomShawn deleted the unified-pool-dvalue branch January 25, 2021 09:27
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 25, 2021
@TomShawn @ti-srebot
cherry pick pingcap#4707 to release-5.0
4c62537 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 25, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4708

TomShawn added a commit that referenced this pull request Jan 25, 2021
@ti-srebot @TomShawn
cherry pick #4707 to release-5.0 (#4708)
1748474 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: TomShawn <[email protected]>
@TomShawn TomShawn assigned Joyinqin and unassigned TomShawn Feb 18, 2021
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Feb 18, 2021
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Feb 18, 2021
@Joyinqin Joyinqin mentioned this pull request Feb 18, 2021
Merged
11 tasks
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees

@Joyinqin Joyinqin

Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @ti-srebot @Joyinqin @sticnarf @CharLotteiu