[codex] Fix settings browser test panel mounting

[juliusmarminge]

What changed

• mount ConnectionsSettings in the three browser tests that assert on connection-management UI

Why

Those tests were rendering GeneralSettingsPanel while asserting on labels and controls that only exist in ConnectionsSettings, so they were testing the wrong component tree.

Validation

• bun fmt
• bun lint
• bun typecheck

Notes

• cd apps/web && bun run test:browser src/components/settings/SettingsPanels.browser.tsx could not run here because the local Playwright Chromium binary is not installed.

Note

Fix blank line formatting in settings browser test panel mounting

Corrects whitespace-only formatting in the settings browser test panel mounting code. No functional changes.

^{Macroscope summarized f852b11.}

---

Note

Low Risk
Low risk: changes are limited to browser tests and only affect which settings panel is mounted for UI assertions.

Overview
Fixes SettingsPanels.browser.tsx browser tests that assert on connection-management UI by mounting ConnectionsSettings instead of GeneralSettingsPanel, so the tests exercise the correct component tree and labels/controls.

^{Reviewed by Cursor Bugbot for commit f852b11. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ea974ccc-b2ab-4cca-b2cb-2d4788de4fd5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/review-settings-panel-tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Diagnostics test now renders wrong component, will fail
  • Restored the test to render GeneralSettingsPanel instead of ConnectionsSettings, since all asserted elements (About, Diagnostics, Open logs folder) only exist in GeneralSettingsPanel.

Or push these changes by commenting:

@cursor push 973fc5f3c7

Preview (973fc5f3c7)

diff --git a/apps/web/src/components/settings/SettingsPanels.browser.tsx b/apps/web/src/components/settings/SettingsPanels.browser.tsx
--- a/apps/web/src/components/settings/SettingsPanels.browser.tsx
+++ b/apps/web/src/components/settings/SettingsPanels.browser.tsx
@@ -357,7 +357,7 @@
 
     await render(
       <AppAtomRegistryProvider>
-        <ConnectionsSettings />
+        <GeneralSettingsPanel />
       </AppAtomRegistryProvider>,
     );

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit aea70e1. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved

Single-line fix to a browser test file that was rendering the wrong component. The test asserted on UI elements only present in GeneralSettingsPanel but was rendering ConnectionsSettings. No production code is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

@cursor push 973fc5f