Skip to content

[codex] Fix settings browser test panel mounting #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Apr 8, 2026
Merged

[codex] Fix settings browser test panel mounting #1842

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea70e1
Fix settings browser panel mounting
Apr 8, 2026
f852b11
fix: restore GeneralSettingsPanel in diagnostics test
cursoragent Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/settings/SettingsPanels.browser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,11 +357,11 @@

await render(
<AppAtomRegistryProvider>
<GeneralSettingsPanel />
<ConnectionsSettings />
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
</AppAtomRegistryProvider>,
);
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
Outdated

await expect.element(page.getByText("About")).toBeInTheDocument();

Check failure on line 364 in apps/web/src/components/settings/SettingsPanels.browser.tsx

View workflow job for this annotation

GitHub Actions / Format, Lint, Typecheck, Test, Browser Test, Build

[chromium] src/components/settings/SettingsPanels.browser.tsx > GeneralSettingsPanel observability > shows diagnostics inside About with a single logs-folder action 

VitestBrowserElementError: Cannot find element with locator: getByText('About')

<body>
  
  


  <div>
    <div
      class="flex-1 overflow-y-auto p-6 sm:p-8"
    >
      <div
        class="mx-auto flex w-full max-w-3xl flex-col gap-8"
      >
        <section
          class="space-y-2.5"
        >
          <div
            class="flex items-center justify-between px-1"
          >
            <h2
              class="flex items-center gap-2 text-[11px] font-semibold uppercase tracking-[0.08em] text-foreground/50"
            >
              <span … />
              Manage local backend
            </h2>
          </div>
          <div
            class="relative overflow-hidden rounded-2xl border bg-card text-card-foreground shadow-sm/4 not-dark:bg-clip-padding before:pointer-events-none before:absolute before:inset-0 before:rounded-[calc(var(--radius-2xl)-1px)] before:shadow-[0_1px_--theme(--color-black/4%)] dark:shadow-none dark:before:shadow-[0_-1px_--theme(--color-white/6%)]"
          >
            <div
              class="border-t border-border/60 px-4 first:border-t-0 sm:px-5 py-4"
            >
              <div … />
            </div>
          </div>
        </section>
        <section
          class="space-y-2.5"
        >
          <div
            class="flex items-center justify-between px-1"
          >
            <h2
              class="flex items-center gap-2 text-[11px] font-semibold uppercase tracking-[0.08em] text-foreground/50"
            >
              <span … />
              Remote environments
            </h2>
            <button
              aria-expanded="false"
              aria-haspopup="dialog"
              class="[&_svg]:-mx-0.5 relative inline-flex shrink-0 cursor-pointer items-center justify-center whitespace-nowrap border font-medium outline-none transition-shadow before:pointer-events-none before:absolute before:inset-0 pointer-coarse:after:absolute pointer-coarse:after:size-full pointer-coarse:after:min-h-11 pointer-coarse:after:min-w-11 focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-1 focus-visible:ring-offset-background disabled:pointer-events-none disabled:opacity-64 [&_svg:not([class*='opacity-'])]:opacity-80 [&_svg]:pointer-events-none [&_svg]:shrink-0 h-7 gap-1 rounded-md px-[calc(--spacing(2)-1px)] text-sm before:rounded-[calc(var(--radius-md)-1px)] sm:h-6 sm:text-xs [&_svg:not([class*='size-'])]:size-4 sm:[&_svg:not([class*='size-'])]:size-3.5 border-input bg-popover not-dark:bg-clip-padding text-foreground shadow-xs/5 not-disabled:not-active:not-data-pressed:before:shadow-[0_1px_--theme(--color-black/4%)] dark:bg-input/32 dark:not-disabled:before:shadow-[0_-1px_--theme(--color-white/2%)] dark:not-disabled:not-active:not-data-pressed:before:shadow-[0_-1px_--theme(--color-white/6%)] [:disabled,:active,[data-pressed]]:shadow-none [:hover,[data-pressed]]:bg-accent/50 dark:[:hover,[data-pressed]]:bg-input/64"
              data-base-ui-click-trigger=""
              data-slot="dialog-trigger"
              id="base-ui-_r_a_"
              tabindex="0"
              type="button"
            >
              <svg … />
              Add environment
            </button>
          </div>
          <div
            class="relative overflow-hidden rounded-2xl border bg-card text-card-foreground shadow-sm/4 not-dark:bg-clip-padding before:pointer-events-none before:absolute before:inset-0 before:rounded-[calc(var(--radius-2xl)-1px)] before:shadow-[0_1px_--theme(--color-black/4%)] dark:shadow-none dark:before:shadow-[0_-1px_--theme(--color-white/6%)]"
          >
            <div
              class="border-t border-border/60 px-4 py-4 first:border-t-0 sm:px-5"
            >
              <p … />
            </div>
          </div>
        </section>
      </div>
    </div>
  </div>
</body>
 ❯ toBeInTheDocument src/components/settings/SettingsPanels.browser.tsx:364:50

Caused by: Caused by: Error: Matcher did not succeed in time.
 ❯ src/components/settings/SettingsPanels.browser.tsx:364:4
await expect.element(page.getByText("Diagnostics")).toBeInTheDocument();
await expect.element(page.getByText("Open logs folder")).toBeInTheDocument();
await expect
Expand Down
Loading