Skip to content

[codex] Fix settings browser test panel mounting #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 2 commits into from
Apr 8, 2026

fix: restore GeneralSettingsPanel in diagnostics test

f852b11
Select commit
Loading
Failed to load commit list.
Merged

[codex] Fix settings browser test panel mounting #1842

fix: restore GeneralSettingsPanel in diagnostics test
f852b11
Select commit
Loading
Failed to load commit list.
MacroscopeApp / Macroscope - Approvability Check succeeded Apr 8, 2026 in 50s

Approved (click on check for details)

  • Eligibility
  • Correctness

Note

More information about how approvability works can be found in our Help Center.

Details

Eligibility
Single-line fix to a browser test file that was rendering the wrong component. The test asserted on UI elements only present in GeneralSettingsPanel but was rendering ConnectionsSettings. No production code is affected.

Notes:
No code owners found in target merge base a5bf3b5

View more details on MacroscopeApp