-
Notifications
You must be signed in to change notification settings - Fork 1.6k
MCPClient streamable_http transport support #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yousifa
commented
Jun 19, 2025
- added streamablehttp support
- bumped mcp version to 1.9.4 (to support streamablehttp)
- added additional_headers and streamable_http params to MCPClient
|
thank you @yousifa ! |
vipyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a branch with some proposed changes. Most deal with recent SSE changes on main. Can you rebase on main and add these changes to this PR @yousifa ?
Feel free to tag @vipyne with any questions.
9d4efc3 to
ef2d8c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove
auth=self._server_params.auth,lines - add comment about
GITHUB_PERSONAL_ACCESS_TOKEN
after that, lgtm!
edit: oh, I still want to take a closer look at the google stuff... could we make the llm in the example google to exercise those code paths? @yousifa
|
@vipyne can we get this in before v0.0.72 👀🙏 |
|
so as I am looking at this, I think the google llm stuff is out of scope here. can you open a separate PR with just those changes? that way this PR & code changes are only about adding the streamable http client. |
|
sure will do now. I will change the example to be with openai then so it doesn't break |
deff945 to
3a7c387
Compare
|
hi @yousifa, I think something went sideways. can you try pulling latest main, then rebasing? |
|
feel free to ping @vipyne on discord and I can help. |
|
yep, i rebased on old main i think, working on it |
3a7c387 to
47ae8a6
Compare
…aders and streamable_http params to MCPClient
47ae8a6 to
1cac028
Compare
|
@vipyne should be good to go |
vipyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your patience! next time run ruff format but lgtm.