Skip to content

Conversation

@yousifa
Copy link
Contributor

@yousifa yousifa commented Jun 19, 2025

  • added streamablehttp support
  • bumped mcp version to 1.9.4 (to support streamablehttp)
  • added additional_headers and streamable_http params to MCPClient

@vipyne vipyne self-requested a review June 24, 2025 16:11
@vipyne
Copy link
Member

vipyne commented Jun 24, 2025

thank you @yousifa !
do you have a favorite (accessible) mcp server that can be used to illustrate a streamablehttp connection ?
perhaps something we can add to examples/foundational/39-* ?

Copy link
Member

@vipyne vipyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a branch with some proposed changes. Most deal with recent SSE changes on main. Can you rebase on main and add these changes to this PR @yousifa ?
Feel free to tag @vipyne with any questions.

@yousifa yousifa force-pushed the mcp-streaming-http branch from 9d4efc3 to ef2d8c7 Compare June 25, 2025 02:09
@yousifa yousifa requested a review from vipyne June 25, 2025 08:47
Copy link
Member

@vipyne vipyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove auth=self._server_params.auth, lines
  • add comment about GITHUB_PERSONAL_ACCESS_TOKEN

after that, lgtm!

edit: oh, I still want to take a closer look at the google stuff... could we make the llm in the example google to exercise those code paths? @yousifa

@yousifa yousifa requested a review from vipyne June 25, 2025 20:13
@yousifa
Copy link
Contributor Author

yousifa commented Jun 26, 2025

@vipyne can we get this in before v0.0.72 👀🙏

@vipyne
Copy link
Member

vipyne commented Jun 26, 2025

@vipyne can we get this in before v0.0.72 👀🙏

@yousifa can you rebase on latest main by any chance? just makes things a little cleaner.
now worries if not. reviewing now. will see re: release.

@vipyne
Copy link
Member

vipyne commented Jun 26, 2025

so as I am looking at this, I think the google llm stuff is out of scope here. can you open a separate PR with just those changes? that way this PR & code changes are only about adding the streamable http client.

@yousifa
Copy link
Contributor Author

yousifa commented Jun 26, 2025

sure will do now. I will change the example to be with openai then so it doesn't break

@yousifa yousifa force-pushed the mcp-streaming-http branch from deff945 to 3a7c387 Compare June 26, 2025 19:01
@vipyne
Copy link
Member

vipyne commented Jun 26, 2025

hi @yousifa, I think something went sideways. can you try pulling latest main, then rebasing?

@vipyne
Copy link
Member

vipyne commented Jun 26, 2025

feel free to ping @vipyne on discord and I can help.

@yousifa
Copy link
Contributor Author

yousifa commented Jun 26, 2025

yep, i rebased on old main i think, working on it

@yousifa yousifa force-pushed the mcp-streaming-http branch from 3a7c387 to 47ae8a6 Compare June 26, 2025 19:14
@yousifa yousifa force-pushed the mcp-streaming-http branch from 47ae8a6 to 1cac028 Compare June 26, 2025 19:18
@yousifa
Copy link
Contributor Author

yousifa commented Jun 26, 2025

@vipyne should be good to go

Copy link
Member

@vipyne vipyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your patience! next time run ruff format but lgtm.

@vipyne vipyne merged commit 3b92113 into pipecat-ai:main Jun 26, 2025
1 check passed
@yousifa yousifa deleted the mcp-streaming-http branch June 26, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants