feature: add publish action #1297
Conversation
| on: | ||
| # Who has permission to workflow_dispatch | ||
| # https://github.com/orgs/community/discussions/26622 | ||
| workflow_dispatch: |
There was a problem hiding this comment.
if: contains('["..."]', github.actor) does not really make sense to me
There was a problem hiding this comment.
workflow_dispatch is a slightly recent feature iirc; maybe they couldn't use the feature at that moment.
I agree with using workflow_dispatch 👍
| # checkout is pinned to dev branch here | ||
| ref: dev | ||
| - name: Setup Node | ||
| uses: actions/setup-node@v3 |
There was a problem hiding this comment.
v4 use node 20 we should update CI before that
| permissions: | ||
| contents: write | ||
| id-token: write |
There was a problem hiding this comment.
|
|
||
| - name: Set package version | ||
| run: | | ||
| yarn lerna version ${{ github.event.inputs.version }} --exact --no-push --yes |
There was a problem hiding this comment.
I'm not sure if we need --force-publish here
| run: | | ||
| git push origin ${{ github.ref_name }} | ||
|
|
||
| - name: Upload Builds |
There was a problem hiding this comment.
Not sure if we want to automate the release tag on Github. There are only 3rd party solutions for now. https://github.com/actions/create-release#github-action---releases-api
.github/workflows/publish.yml
Outdated
| - name: Set package version | ||
| run: | | ||
| yarn lerna version ${{ github.event.inputs.version }} --exact --no-push --yes | ||
| yarn lerna publish from-git --dist-tag latest |
There was a problem hiding this comment.
it would be cool if we could make the disttag variable
|
let's try whether it's working properly |
#1294
Description