deps: Bump three to r160 #1348
Merged
deps: Bump three to r160 #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The type parameter of `THREE.Object3D` is no longer required (used to be `THREE.Object3D<THREE.Event>` - `THREE.UniformsUtils.merge` now has more appropriate typing which breaks the existing code, workarounded with `as any`
Starting from r155, the light unit is set to physically based one by default. We need to multiply the directional light intensity by PI because of this change. See: mrdoob/three.js#26392
also removed an impossible compat code path
0b5vr
force-pushed
the
bump-three-r160
branch
from
bdaf2c7
to
3deb0b8
Compare
|
rebase ✅ |
ke456-png
reviewed
Jan 16, 2024
packages/three-vrm-materials-hdr-emissive-multiplier/examples/loader-plugin.html
Show resolved
Hide resolved
|
I checked examples are working in three.js r160 & r154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will bump Three.js to r160.
I checked that all examples are working properly.