Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Bump three to r160 #1348

Merged
merged 3 commits into from
Jan 17, 2024
Merged

deps: Bump three to r160 #1348

merged 3 commits into from
Jan 17, 2024

Commits on Jan 15, 2024

  1. deps: Bump three.js to r160 

    - The type parameter of `THREE.Object3D` is no longer required (used to be `THREE.Object3D<THREE.Event>`
- `THREE.UniformsUtils.merge` now has more appropriate typing which breaks the existing code, workarounded with `as any`
    @0b5vr
    0b5vr committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    77e09f2 View commit details
    Browse the repository at this point in the history

  2. examples: Change light intensity from 1 to PI 

    Starting from r155, the light unit is set to physically based one by default.
We need to multiply the directional light intensity by PI because of this change.

See: mrdoob/three.js#26392
    @0b5vr
    0b5vr committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    82b3f09 View commit details
    Browse the repository at this point in the history

  3. refactor: add COMPAT comment on pre-r156 compats addressed in #1304 

    also removed an impossible compat code path
    @0b5vr
    0b5vr committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3deb0b8 View commit details
    Browse the repository at this point in the history