Presidecms 3289 open count bug

[madmikede]

for the first opening of an email, the open_count field wasn't set correctly, because the field name was opened_count.

To correct the statistics afterwards, here's some sql:

-- One-off backfill: repair psys_email_template_send_log.open_count
--
-- Background: markAsOpened() used opened_count instead of open_count on the first
-- open, so many rows have opened = 1 but open_count = 0 (or open_count too low).
--
-- Run against the Preside datasource (MySQL). Table prefix psys_ is the default
-- for system objects; adjust if your environment uses a different prefix.
--
-- Suggested workflow:
--   1. Run the preview SELECT below and review counts.
--   2. Take a DB backup.
--   3. Run steps 1 and 2 in a transaction (COMMIT when satisfied).

-- ---------------------------------------------------------------------------
-- Preview: rows that will be affected
-- ---------------------------------------------------------------------------
SELECT
    COUNT(*) AS rows_opened_but_zero_count
FROM psys_email_template_send_log
WHERE opened = 1
  AND COALESCE(open_count, 0) = 0;

SELECT
    l.id,
    l.recipient,
    l.opened,
    l.open_count AS current_open_count,
    COALESCE(sub.activity_open_count, 0) AS activity_open_count
FROM psys_email_template_send_log AS l
LEFT JOIN (
    SELECT message, COUNT(1) AS activity_open_count
    FROM psys_email_template_send_log_activity
    WHERE activity_type = 'open'
    GROUP BY message
) AS sub ON sub.message = l.id
WHERE l.opened = 1
  AND COALESCE(l.open_count, 0) = 0
LIMIT 50;

-- ---------------------------------------------------------------------------
-- Backfill (run inside a transaction)
-- ---------------------------------------------------------------------------
-- START TRANSACTION;

-- Step 1: set open_count from recorded "open" activities (source of truth)
UPDATE psys_email_template_send_log AS l
INNER JOIN (
    SELECT COUNT(1) AS n, message
    FROM psys_email_template_send_log_activity
    WHERE activity_type = 'open'
    GROUP BY message
) AS sub ON sub.message = l.id
SET l.open_count = sub.n
WHERE COALESCE(l.open_count, 0) <> sub.n;

-- Step 2: opened = 1 but still no count (e.g. no activity row was stored)
UPDATE psys_email_template_send_log
SET open_count = 1
WHERE opened = 1
  AND COALESCE(open_count, 0) = 0;

-- COMMIT;
-- ROLLBACK;

-- ---------------------------------------------------------------------------
-- Verify
-- ---------------------------------------------------------------------------
SELECT COUNT(*) AS remaining_opened_but_zero_count
FROM psys_email_template_send_log
WHERE opened = 1
  AND COALESCE(open_count, 0) = 0;

[madmikede]

Please acknowledge: Due to the change, the Service for the unit test also needed a modification!