Skip to content

Presidecms 3289 open count bug #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madmikede wants to merge 3 commits into
base: stable
Choose a base branch
from
+3 −3
Open

Presidecms 3289 open count bug #1783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72f7195
PRESIDECMS-3289 corrected the field name from opener_count to open_count
madmikede May 22, 2026
50ad29c
removed settings.json for vscode
madmikede May 22, 2026
b09d5e1
PRESIDECMS-3289 Due too the typo the test also needs to be modified.
madmikede Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/services/email/EmailLoggingService.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ component {
, string ipAddress = cgi.remote_addr
, date eventDate = Now()
) {
var data = { opened = true, opened_count=1 };
var data = { opened = true, open_count=1 };

if ( !arguments.softMark ) {
data.opened_date = _getNow();
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/api/email/EmailLoggingServiceTest.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ component extends="resources.HelperObjects.PresideBddTestCase" {
expect( mockLogDao.$callLog().updateData[ 1 ] ).toBe( {
filter = "id = :id and ( opened is null or opened = :opened )"
, filterParams = { id=logId, opened=false }
, data = { opened=true, opened_date=nowish, opened_count=1 }
, data = { opened=true, opened_date=nowish, open_count=1 }
} );
expect( service.$callLog().markAsDelivered.len() ).toBe( 1 );
expect( service.$callLog().markAsDelivered[1] ).toBe( [ logId, true ] );
Expand All @@ -356,7 +356,7 @@ component extends="resources.HelperObjects.PresideBddTestCase" {
expect( mockLogDao.$callLog().updateData[ 1 ] ).toBe( {
filter = "id = :id and ( opened is null or opened = :opened )"
, filterParams = { id=logId, opened=false }
, data = { opened=true, opened_count=1 }
, data = { opened=true, open_count=1 }
} );
expect( service.$callLog().markAsDelivered.len() ).toBe( 1 );
expect( service.$callLog().markAsDelivered[1] ).toBe( [ logId, true ] );
Expand Down
Loading