Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group datasets by meta.Crop #466

Closed
Don-Isdale opened this issue Dec 17, 2024 · 2 comments
Closed

group datasets by meta.Crop #466

Don-Isdale opened this issue Dec 17, 2024 · 2 comments
Assignees

Comments

@Don-Isdale
Copy link
Collaborator

Don-Isdale commented Dec 17, 2024

part of #465


group datasets by meta.Crop (initially considered meta.cropName)

@Don-Isdale
Copy link
Collaborator Author

Changes Implemented

Updated the library which will be used for this work :
8e927a4 update filter-group

Don-Isdale added a commit that referenced this issue Jan 2, 2025
part of #465 : #466, #467.
manage-explorer.js :
 dataPre1() : insert filter by .cropFilterSelected.
 dataPre() : rename to dataPostNameFilter, and use alias to define it, so that filters can be inserted easily (dataPre is used in several places); e.g. dataPostCrop() was drafted to implement the crop filter, which is now implemented in dataPre1(), upstream of the name filter, whereas dataPre is downstream of the name filter, as indicated by the name dataPostNameFilter.
 add noCrop, cropFilterSelected, selectedCropChanged, cropField, withCrop, child1Crop, cropNames (these are based on respectively noGroup, groupFilterSelected, selectedGroupChanged, withParent, child1, parents, parentNames, substituting parent → crop).
 add cropsForFilter.

dataset.js : add cropName : alias(_meta.Crop).
filter-group.js : toString() : reduce trace.
manage-explorer.hbs : Use form/select-group, with .cropFilterSelected, .cropsForFilter, .selectedCropChanged
@Don-Isdale
Copy link
Collaborator Author

Implementation update

Because only filtering and not grouping is required, it was sufficient, and simpler, to implement the Crop Names list using computed properties based on withParent / parentNames.

The list is displayed for user selection, using select-group which is used for the Group selector.

These changes are recorded in this comment.

Tested on local

Screenshots demonstrated the implemented functionality are recorded in #467 in this comment.

@Don-Isdale Don-Isdale changed the title group datasets by _meta.cropName group datasets by meta.Crop Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant