Usability and GUI presentation improvements (431) #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server connected Closes #437. select-server.hbs : use this. prefix for component attribute .servers, part of framework upgrade #370. left-panel.js : alias multipleServers because its basis may change; for hiding Panel::SelectedServer. api-server.js : featuresCountAllTaskInstance() : call to getBlocksTask / getBlocksLimits : change param blockIds from [] to undefined, i.e. default to all blocks; passing [] was an error in 126a15a which added this function. api-servers.js : add multipleServersCP(), which enables panel/left-panel.hbs to update whereas using multipleServers does not. left-panel.hbs : hide Panel::SelectedServer if not multipleServers.
... i.e. Germinate / Gigwa / secondary servers / multiple-backends. Closes #436. manage-explorer.hbs : hide form/api-servers if ! .urlOptions.dataSources hide if ! .multipleServersCP : <BsTab <BsNav {{#each-in this.servers ... api-server-tab ... (as noted in comments in b550d0d, multipleServersCP updates OK in this context whereas multipleServers does not)
…el-container Closes #438. manage-explorer.js : add initialSelected() : select All Datasets when the BsTab is re-created; as commented, @activeId={{this.activeId}} is passed to <BsTab > so this should not be necessary - recheck after next framework update. manage-explorer.hbs : Use .initialSelected when dataset type BsTab (datasetTypeTabId) is inserted.
frontend/package-lock.json : npm install, to match update of version in frontend/package.json in 3e90d9d
update frontend/package-lock.json using : npm install --package-lock-only because the container image build is failing; one of the errors is Missing: [email protected] from lock file
frontend/package{,-lock}.json : add ember-local-storage: ^2.0.7,
this is available in npm as @2.0.7, from github.com/funkensturm/ember-local-storage
Closes #439. genotype-search.hbs : wrap with <div class=panel-section> (the Ember classic Components use classNames: [panel-section], which is also available via manage-base).
…test that
The update of path-data.js : inside() enabled testing one of the changed components style-editor, which applies to synteny-blocks rendered via path-data.
import ember-local-storage without a namespace, which was previously @facilecomm/ :
style-editor.js
view.js
block-view-history.js
user-conf-data.js
block-adj.js :
handle undefined .lastSuccessful
path-data.js : inside() : change params ak1, ak2 to ax1, ax2, i.e. from blockId to axis-1d; this change can be applied also to featureLineS{,2,3}()
frontend/package{,-lock}.json : previous commit 475eb8c did npm install ember-local-storage, but omitted to do npm uninstall @facilecomm/ember-local-storage, which this commit does.
entry-blocks-array.js : dataFiltered() : sort the result data by .name. This sorts the Block / Chromosome names within Dataset Explorer tabs other than All Datasets, which already has sorted Block / Chromosome names.
Closes 428. The issue was that a typo (e.g. missing double quotes around blocks) in JSON upload displays in GUI as [object Object]. upload.js : uploadParsedCb() and uploadParsedTryCb() : replace Error( with ErrorStatus(400, . The required change was for augmentedMessage in uploadParsedTryCb(); the other 3 Error()-s are similar so the same change was applied. Probably required also in Dataset.upload() and handleJson(), which is used by blockFeaturesAdd - which is used from the command line not the GUI.
…format error
middleware.json : add final:after { strong-error-handler } to prevent JSON error response being converted to HTML e.g. for cb(ErrorStatus(400, augmentedMessage)); previous commit eac5e14 worked in local (both development and production builds), but not in container (AlpineLinux) on AWS; this change enables it to work also in the container.
Also capitalise the 2nd D in includeSubdomains, in response to warning : Strict-Transport-Security middleware should use includeSubDomains instead of includeSubdomains. (The correct one has an uppercase D.)
…orer manage-explorer.js : initialSelected() : reduce delay 5 -> 2.5sec
{,frontend/}package.json : version : 3.2.0 -> 3.3.0
…anel Usability and GUI presentation improvements (431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the completion of #431, which contains these sub-issues :
Development branch : feature/guiChangesLeftPanel