Populate site_imports from sites.imported_data in CE (#4155)

* populate site_imports from sites.imported_data in CE * not dry_run? * Wrap data migration using `with_repo` to ensure ClickhouseRepo is running * Do not create funnels in seeds when running CE * Remove migrator wrapper * Explicitly raise on rollback attempt * Put a warning in data migration scripts which are put in migrations --------- Co-authored-by: Adrian Gruntkowski <[email protected]>
plausible · May 29, 2024 · dc7243f · dc7243f
1 parent 55dfe4c
commit dc7243f
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 9 deletions.
diff --git a/lib/plausible/data_migration/site_imports.ex b/lib/plausible/data_migration/site_imports.ex
@@ -1,9 +1,10 @@
 defmodule Plausible.DataMigration.SiteImports do
   @moduledoc """
+  !!!WARNING!!!: This script is used in migrations. Please take special care
+  when altering it.
+
   Site imports migration backfilling SiteImport entries for old imports
   and alters import end dates to match actual end date of respective import stats.
-
-
   """
 
   import Ecto.Query

diff --git a/lib/plausible/data_migration/versioned_sessions.ex b/lib/plausible/data_migration/versioned_sessions.ex
@@ -1,6 +1,11 @@
 defmodule Plausible.DataMigration.VersionedSessions do
   @moduledoc """
-  Sessions CollapsingMergeTree -> VersionedCollapsingMergeTree migration, SQL files available at:
+  !!!WARNING!!!: This script is used in migrations. Please take special care
+  when altering it.
+
+  Sessions CollapsingMergeTree -> VersionedCollapsingMergeTree migration,
+  SQL files available at:
+
   priv/data_migrations/VersionedSessions/sql
   """
   use Plausible.DataMigration, dir: "VersionedSessions", repo: Plausible.IngestRepo

diff --git a/priv/repo/migrations/20240528115149_migrate_site_imports.exs b/priv/repo/migrations/20240528115149_migrate_site_imports.exs
@@ -0,0 +1,14 @@
+defmodule Plausible.Repo.Migrations.MigrateSiteImports do
+  use Plausible
+  use Ecto.Migration
+
+  def up do
+    if ce?() do
+      Plausible.DataMigration.SiteImports.run(dry_run?: false)
+    end
+  end
+
+  def down do
+    raise "Irreversible"
+  end
+end
diff --git a/priv/repo/seeds.exs b/priv/repo/seeds.exs
@@ -79,12 +79,14 @@ seeded_token = Plausible.Plugins.API.Token.generate("seed-token")
 {:ok, _goal5} = Plausible.Goals.create(site, %{"page_path" => Enum.random(long_random_paths)})
 {:ok, outbound} = Plausible.Goals.create(site, %{"event_name" => "Outbound Link: Click"})
 
-{:ok, _funnel} =
-  Plausible.Funnels.create(site, "From homepage to login", [
-    %{"goal_id" => goal1.id},
-    %{"goal_id" => goal2.id},
-    %{"goal_id" => goal3.id}
-  ])
+if Plausible.ee?() do
+  {:ok, _funnel} =
+    Plausible.Funnels.create(site, "From homepage to login", [
+      %{"goal_id" => goal1.id},
+      %{"goal_id" => goal2.id},
+      %{"goal_id" => goal3.id}
+    ])
+end
 
 put_random_time = fn
   date, 0 ->