-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v5] breaking: make use-sync-external-store an optional peer dependency #2237
[v5] breaking: make use-sync-external-store an optional peer dependency #2237
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c62f55c:
|
"optional": true | ||
}, | ||
"react": { | ||
"optional": true | ||
}, | ||
"use-sync-external-store": { | ||
"optional": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted to make this optional because it is only used with react
which is also optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my intention. I forgot react was already optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"optional": true | ||
}, | ||
"react": { | ||
"optional": true | ||
}, | ||
"use-sync-external-store": { | ||
"optional": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my intention. I forgot react was already optional.
Oooops, we forgot to remove |
Summary
Check List
yarn run prettier
for formatting code and docs