Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoSin annotations #1520

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

chriscrsmith
Copy link
Contributor

So far this includes only the annotations.py file. Waiting on #1514 to add PhoSin to catalog.

@andrewkern, how do we upload files to AWS? Currently the interval files are sitting here:

http://sesame.uoregon.edu/~chriscs/StdPopSim/Phocoena_sinus.mPhoSin1.pri.110_exons.tar.gz
http://sesame.uoregon.edu/~chriscs/StdPopSim/Phocoena_sinus.mPhoSin1.pri.110_CDS.tar.gz

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (039df54) 99.85% compared to head (a8f3928) 99.85%.

❗ Current head a8f3928 differs from pull request most recent head 57034a6. Consider uploading reports for the commit 57034a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
- Coverage   99.85%   99.85%   -0.01%     
==========================================
  Files         127      121       -6     
  Lines        4260     4178      -82     
  Branches      591      588       -3     
==========================================
- Hits         4254     4172      -82     
  Misses          3        3              
  Partials        3        3              

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nspope
Copy link
Collaborator

nspope commented Oct 18, 2023

i'm going to rerun the test suite, to see if #1532 actually worked (looks like all but one of the grid errored out with "conda environment not found")

@chriscrsmith
Copy link
Contributor Author

chriscrsmith commented Oct 18, 2023

Hey @nspope not sure if it's relevant but this won't pass the stdpopsim pytest until we get these files uploaded to AWS

@nspope
Copy link
Collaborator

nspope commented Oct 18, 2023

that's fine-- just need to get the test suite to run in the first place! Which it seems they aren't, despite #1532

@nspope
Copy link
Collaborator

nspope commented Oct 18, 2023

@chriscrsmith would you mind rebasing this onto main? I think I've fixed the CI issues, and want to check that the tests actually run now (regardless of whether they fail).

small changes

md5sums updated
@chriscrsmith
Copy link
Contributor Author

Hows that look, @nspope ? I see some tests running...

@nspope
Copy link
Collaborator

nspope commented Oct 18, 2023

Seems to be working, thanks!

@nspope nspope mentioned this pull request Oct 18, 2023
@andrewkern
Copy link
Member

@chriscrsmith I think the correct way to do this is to actually to merge this PR and then run the annotation maintenance and it will automatically do the downloading etc.

anyone mind if I do that?

@andrewkern andrewkern merged commit a588724 into popsim-consortium:main Oct 25, 2023
3 of 9 checks passed
@andrewkern
Copy link
Member

the annotations are now up on aws

@chriscrsmith chriscrsmith mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants