-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update actions to use google-github-actions/auth@v1 and fix input syntax #118
Conversation
Mea culpa, I should have noticed that when I reviewed #117 as we had already run into the same thing in the metamist repo. I previously made a similar change to this one to fix the same accident in populationgenomics/metamist#550, but we took the opportunity to move to use a federated identity instead in populationgenomics/metamist#553. Possibly that's something we would want to do in this repo too? |
Hey @EddieLF, @jmarshall beat me to the suggestion, it's unclear to me at this stage which permissions one needs to do this so I've done it and added a couple of commits to your branch to address this. (Test run: https://github.com/populationgenomics/images/actions/runs/6896771022/job/18763560951) |
This quiet change in action parameters is exactly the sort of thing that actionlint should be able to detect. It knows about a bunch of common actions but so far not this one. However I've built a version locally that does, so hopefully we won't make this mistake again! And also proposed adding it upstream — see rhysd/actionlint#380. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels weird approving, but good to get this out
I'm going to revoke the gh-images-deployer credentials, keep an eye out for anything weird. |
So it looks like the new version of
google-github-actions/setup-gcloud@v1
action no longer usesservice_account_key
as input. See this failed deploy, under the gcloud setup header.Which is leading to a fail in the
deploy config toml
step.From the actions repo, it looks like they now require use of the
google-github-actions/auth
action to first auth with theservice_account_key
(now calledcredentials_json
) before running the gcloud setup.Also updates the
.github/workflows/deploy_container.yaml
to use the@v1
version of the gcloud setup as well.