Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TRTools to v6.0.2 #171

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Update TRTools to v6.0.2 #171

merged 10 commits into from
Oct 31, 2024

Conversation

hopedisastro
Copy link
Contributor

@hopedisastro hopedisastro commented Oct 31, 2024

This version incorporates the --vcfs-list parameter that will hopefully resolve the mergeSTR issuehttps://centrepopgen.slack.com/archives/C030X7WGFCL/p1730386942089209.

Had to change ARG VERSION to 'VER' because it was automatically adding an extra 'v' to 6.0.2 - resulting in a failure to find the version in conda

@jmarshall
Copy link
Contributor

When you're manually running the deploy_container workflow, are you putting v6.0.2 for Tag of image?

I think that's where the mystery v is coming from. Type in 6.0.2 instead — which is what the automatic run will do when this is eventually merged — and I think you will be able to remove all this hardcoding. 😄

@hopedisastro
Copy link
Contributor Author

Ok, works now without hardcoding.

Copy link
Contributor

@jmarshall jmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with that v sorted out, the micromamba update wouldn't be necessary — but it's an improvement anyway so let's leave it in!

@hopedisastro hopedisastro merged commit d8aa769 into main Oct 31, 2024
3 checks passed
@hopedisastro hopedisastro deleted the trtools_update_v6 branch October 31, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants