Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/update-existing-cohort-parser-wi…
Browse files Browse the repository at this point in the history
…th-skip-flag' into update-existing-cohort-parser-with-skip-flag
  • Loading branch information
michael-harper committed Nov 20, 2023
2 parents 2aec9dc + 9f0909c commit 20af8c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/parse_existing_cohort.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def get_existing_external_sequence_ids(self, participant_map: dict[str, dict]):
'--allow-missing-files',
'allow_missing_files',
is_flag=True,
help='Set this flag to parse manifests with missing data',
help='Set this flag to parse/ingest sequencing groups with missing reads',
)
@click.argument('manifests', nargs=-1)
@run_as_sync
Expand Down
2 changes: 1 addition & 1 deletion test/test_parse_existing_cohort.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ async def test_existing_row(

@run_as_sync
async def test_get_read_filenames_no_reads_fail(self):
"""Test when allow_missing_files is False and records with missing fastqs, ValueError is raised"""
"""Test ValueError is raised when allow_missing_files is False and sequencing groups have no reads"""

single_row = {Columns.MANIFEST_FLUID_X: ''}

Expand Down

0 comments on commit 20af8c6

Please sign in to comment.