Gotcha!

populationgenomics · Jun 13, 2024 · 550110e · 550110e
1 parent c906797
commit 550110e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/db/python/tables/sample.py b/db/python/tables/sample.py
@@ -90,8 +90,10 @@ def construct_query(
         ]
 
         if needs_eid:
+            # 2024-06-15 mfranklin: left join, inner join, doesn't matter as there
+            #       should always be an external_id
             query_lines.append(
-                'INNER JOIN sample_external_id seid ON seid.sample_id = ss.id'
+                'LEFT JOIN sample_external_id seid ON seid.sample_id = ss.id'
             )
         if needs_sequencing_group:
             query_lines.append('INNER JOIN sequencing_group sg ON sg.sample_id = ss.id')
@@ -124,6 +126,7 @@ def construct_query(
             INNER JOIN (
             {query}
             ) as inner_query ON inner_query.id = s.id
+            GROUP BY s.id
         """
 
         return outer_query, values