Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionality from SG update endpoint #531

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Remove functionality from SG update endpoint #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions api/routes/sequencing_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,10 @@
# region CREATES


class SequencingGroupUpdateModel(BaseModel):
class SequencingGroupMetaUpdateModel(BaseModel):
"""Update sequencing group model"""

meta: dict[str, Any] | None = None
platform: str | None = None
technology: str | None = None
type: str | None = None


@router.get('{sequencing_group_id}', operation_id='getSequencingGroup')
Expand Down Expand Up @@ -62,7 +59,7 @@ async def get_all_sequencing_group_ids_by_sample_by_type(
@router.get('/project/{sequencing_group_id}', operation_id='updateSequencingGroup')
async def update_sequencing_group(
sequencing_group_id: str,
sequencing_group: SequencingGroupUpdateModel,
sequencing_group: SequencingGroupMetaUpdateModel,
connection: Connection = get_project_write_connection,
) -> bool:
"""Update the meta fields of a sequencing group"""
Expand All @@ -72,9 +69,6 @@ async def update_sequencing_group(
SequencingGroupUpsertInternal(
id=sequencing_group_id_transform_to_raw(sequencing_group_id),
meta=sequencing_group.meta,
platform=sequencing_group.platform,
technology=sequencing_group.technology,
type=sequencing_group.type,
)
]
)
Expand Down
Loading