Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address mypy errors #546

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Address mypy errors #546

merged 7 commits into from
Sep 18, 2023

Conversation

illusional
Copy link
Collaborator

Lots of random fixes:

  • Upgrade strawberry to latest version for graphql type fixes
  • Patching instead of assigning a magic mock
  • Asserting search response in tests to avoid type error from union
  • Find + replace "sequence_group" with "sequencing_group"
  • My new VSCode wants to sort imports
  • Comment out broken code with TODOs
  • Fix a lot of bad keys for models that are silently ignored
  • Fix some reassigning of variables

danielreti
danielreti approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@danielreti danielreti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many little fixes!

EddieLF
EddieLF approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@EddieLF EddieLF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the import sorting! Removing the references to sequences is also great, and I definitely like the generic auditor tests using mock patches rather than MagicMock. ✅✅✅

@illusional
Copy link
Collaborator Author

Double green ticks ✅ !

@illusional illusional merged commit 57ca4d3 into dev Sep 18, 2023
2 checks passed
@illusional illusional deleted the fix-linting branch September 18, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielreti danielreti danielreti approved these changes

@EddieLF EddieLF EddieLF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illusional @EddieLF @danielreti