Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graphql link + changed title to metamist #549

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

danielreti
Copy link
Contributor

Closes #544

Copy link
Collaborator

@illusional illusional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve because it is a win, but highlighting this comment, the solution in this PR will kick you out of the React app, and onto a separate graphiql page (unlike the /swagger page), as the page is served directly from Python.

Edit: Can you merge from dev, as I've merged the linting fixes

@danielreti
Copy link
Contributor Author

Agree - but couldn't quickly find a neat solution to serve it from React and figured it wasn't worth the effort+time for such a simple fix. Is there any detriment to leaving the React app?

@illusional illusional merged commit b95ca51 into dev Sep 20, 2023
2 checks passed
@illusional illusional deleted the add-graphql-to-navbar branch September 20, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage link to GraphQl
2 participants