Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

my code don't jiggle jiggle, it folds #552

Merged
merged 2 commits into from
Sep 25, 2023
Merged

my code don't jiggle jiggle, it folds #552

merged 2 commits into from
Sep 25, 2023

Conversation

MattWellie
Copy link
Contributor

jiggle jiggle

Just been hacking around this morning

  • Swaps out Click for ArgParse
  • Makes random/specific args independent
  • removes _prefixes on variables & methods, we ain't writing Java here
  • deletes some unused methods (not the random weighted sampling one)
  • adjusts return types and docstring on some methods

@MattWellie MattWellie marked this pull request as ready for review September 19, 2023 01:18
vivbak
vivbak approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@vivbak vivbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@vivbak vivbak merged commit 14c0a3a into fix-test-subset-analysis Sep 25, 2023
2 checks passed
@vivbak vivbak deleted the fix-test-subset-analysis-jiggle branch September 25, 2023 04:58
vivbak added a commit that referenced this pull request Sep 27, 2023
@vivbak @MattWellie
Fix test subset script (#519)
44563e0 
* add family sg function + silence the linter

* Lots of changes tbh

* Remove interactivity. Remove validation
- As we run scripts via AR, the interactivity never makes sense.
- Most of the validation is inaccurate now, as those use cases have been handled

* Fixes + Cleanup

* my code don't jiggle jiggle, it folds (#552)

Co-authored-by: vivbak <[email protected]>

* respond to feedback

* Fixes haha

* remove gross for-loop + fixes

* respond to feedback

* Add more logs

---------

Co-authored-by: Matt Welland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivbak vivbak vivbak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattWellie @vivbak