Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture specific environment variables on write #721

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

illusional
Copy link
Collaborator

No-op change for most people, but capture more provenance information.
I tested this locally and it works.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 76.40%. Comparing base (e098d13) to head (7342efc).

Files Patch % Lines
api/utils/db.py 11.76% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #721      +/-   ##
==========================================
- Coverage   76.50%   76.40%   -0.10%     
==========================================
  Files         148      148              
  Lines       11797    11814      +17     
==========================================
+ Hits         9025     9027       +2     
- Misses       2772     2787      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@milo-hyben milo-hyben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@illusional illusional merged commit 5574143 into dev Apr 3, 2024
5 checks passed
@illusional illusional deleted the capture-hail-batch-env-vars branch April 3, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants