Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pseudo contributor role w/o readonly reqs, but write access #777

Merged
merged 4 commits into from
May 15, 2024

Conversation

illusional
Copy link
Collaborator

Short term hack for: #703

  1. Check readonly
  2. Then update the connection to make it non-readonly.

Though this gently points out that someone could update the connection.readonly attribute to False anywhere in the code, maybe this should be frozen.

api/utils/db.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.08%. Comparing base (60d67d1) to head (c43a157).

Files Patch % Lines
api/utils/db.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #777      +/-   ##
==========================================
- Coverage   77.12%   77.08%   -0.04%     
==========================================
  Files         157      157              
  Lines       12957    12967      +10     
==========================================
+ Hits         9993     9996       +3     
- Misses       2964     2971       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dancoates dancoates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a weird unrelated lint error that needs fixing by the looks of it

Copy link
Contributor

@jmarshall jmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the linter didn't complain about has_participant_join in the PR in which it was recently added, but 🤷 …

@illusional illusional merged commit d21e399 into dev May 15, 2024
5 checks passed
@illusional illusional deleted the add-pseudo-contributor-role branch May 15, 2024 00:48
@illusional illusional mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants