🐛 Fix for graphQL when query project->cohorts by id.#805
Merged
milo-hyben merged 1 commit intodevfrom May 29, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #805 +/- ##
=======================================
Coverage 77.30% 77.30%
=======================================
Files 157 157
Lines 13010 13010
=======================================
Hits 10057 10057
Misses 2953 2953 ☔ View full report in Codecov by Sentry. |
jmarshall
approved these changes
May 29, 2024
Contributor
jmarshall
left a comment
jmarshall
left a comment
There was a problem hiding this comment.
I haven't completely convinced myself that there aren't any similar problems elsewhere as well, but this instance and fix is LGTM.
Contributor
|
Thanks @milo-hyben! Annoyingly, in my assorted fixes PR I fixed this exact issue with the cohort_template and yet skipped the cohort id itself!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is s simple fix when query project -> cohorts by string id.