Update generic_parser from_json return after ingestion #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
generic_parser.from_json
function return the full response it receives from Metamist.When the parser is used to ingest from a manifest, the parser is instantiated:
We then call
parser.from_manifest_path
This returns
parser.parse_manifest
, which in turn returnsparser.from_json
. Currently,from_json
has no returned value unless the--dry-run
flag is set.This means that nothing can be done to analyse the response beyond what gets logged by the generic parser.
By adding a
return result
tofrom_json
, the result/response can be printed or analysed by any custom parser implementation.