-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved table filtering #823
Improved table filtering #823
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ourdna/update-table-view-and-filtering #823 +/- ##
==========================================================================
+ Coverage 79.20% 79.33% +0.12%
==========================================================================
Files 162 168 +6
Lines 14040 14168 +128
==========================================================================
+ Hits 11121 11240 +119
- Misses 2919 2928 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the quick review and as per our quick chat, I would only rename 'db_filters' to 'filters'
This reads better:
from db.python.filters import GenericFilter
than:
from db.python.db_filters import GenericFilter
Will wait till you merge both PRs into one.
e1a94ad
into
ourdna/update-table-view-and-filtering
NB: This is built on #742, so there will be some strange diffs, because some of the participant query changes were created there.