Update fix_pbmc_sample_participant.py script for multiple external ids #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand sample_map_by_external_id to hold all the external_ids for all the samples. For samples with an external_id containing '-PBMC', use next(...) to pick the first such external_id -- generally there'll surely only be one anyway.
|
Incorporated into PR #866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't previously audit the ad-hoc scripts directory too carefully… having now done so, alongside create_test_subset.py I think this is the only one needing adjustments.
Expand
sample_map_by_external_idto hold all the external_ids for all the samples. For samples with an external_id containing '-PBMC', usenext(...)to pick the first such external_id — generally there'll surely only be one anyway.