Upgrade to dev version of strawberry graphql to improve performance of resolvers with generic inputs #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version includes a fix for the issue where result sets that included many items with a resolver that used a generic input type would be very slow.
illusional
approved these changes
Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #841 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 161 161
Lines 13622 13622
=======================================
Hits 10782 10782
Misses 2840 2840 ☔ View full report in Codecov by Sentry. |
|
This has been released in Strawberry 0.235.1 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is a issue with strawberry graphql which causes performance issues in cases where the field type for a large result set uses a generic input type. There is an outline of this issue here: strawberry-graphql/strawberry#3544 and the PR with the fix is here strawberry-graphql/strawberry#3549
This PR upgrades to the new dev version of strawberry which version includes a fix for the issue. Once an official release is out we can upgrade again.