Update project_insights code to account for multiple family external ids changes #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that as for pext.external_id and sext.external_id, this might benefit from being aggregated (or maybe joining also on fext.name = '') as at present multiple rows may be returned if an item actually does have multiple external ids.
Invoke this in a test case; for now, we don't validate the results as it returns [] as we haven't set up enough data to get a proper result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #986 +/- ##
==========================================
+ Coverage 81.54% 81.75% +0.21%
==========================================
Files 184 184
Lines 15965 15969 +4
==========================================
+ Hits 13018 13056 +38
+ Misses 2947 2913 -34 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on the final phase of merging #896, I did not exhaustively recheck the code base for newly arrived references to the soon-to-be-obsolete
family.external_idfield. Since that PR had been begun, this code had been merged and uses this field. And unluckily the project_insights test cases tested only the summary not the details, so the old field access was not detected via the unit tests.Fix this instance to use the new separate
family_external_idtable, and add a details test case that just causes the relevant code to be run.Note that as for
pext.external_idandsext.external_id, this might benefit from being aggregated (or alternatively maybe joining also onfext.name = '') as at present multiple rows may be returned if an an item actually does have multiple external ids. But that can be adjusted as and when it actually occurs.