Release#994
Merged
milo-hyben merged 2 commits intomainfrom Nov 21, 2024
Merged
Conversation
* Update vcgs fastq filename regex pattern * Add TWIST library type for some cases * Lint
* Script to upsert MGRB participants * Fixed linting. * Bump pip packages. * Bump fastapi package. * Type hinting * Adding ability to pull metadata files from main or test upload buckets * Adding ability to pull metadata files from main or test upload buckets * Linting * Changing create_participant() so that it returns Participantupsert object that we then append to a list. This list is then handed to ParticipantApi().upsert_participants() function so that only one call is made * Allowing more flexible approach to name of column in sample metadata file that contains sample external id * Linting * Renaming filename to remove project name * Linting * Bump yarl and aiohttp pip packages. --------- Co-authored-by: Milo Hyben <milo.hyben@gmail.com>
vivbak
approved these changes
Nov 21, 2024
Contributor
vivbak
left a comment
vivbak
left a comment
There was a problem hiding this comment.
Don't forget to not squash like I forget every time 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.