Add MLD_CONFIG_NAMESPACE_PREFIX #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements configurable namespace prefixes for mldsa-native, following the same pattern as mlkem-native's
MLK_CONFIG_NAMESPACE_PREFIX
. The changes enable flexible symbol namespacing while maintaining full compatibility with existing CBMC proofs and tests.The level specific namespacing, e.g.
MLD_NAMESPACE_PREFIX_K
will come in a following PR that implements the multi-level build configuration along withMLD_CONFIG_MULTILEVEL_WITH_SHARED
,MLD_CONFIG_MULTILEVEL_NO_SHARED
, and the level specific namespace e.g.MLD_NAMESPACE_KL
. Reason being, it's much easier to work with CI when making smaller chunk step-wise infrastructure changes like these.Discussion points: We inherited
namespace
andnamespacetop
from upstream Dilithium. The upstream Kyber doesn't have this split. I've maintained it in this PR, but this may be a good time to assess it's presence.