Add mldsa-native.h API header file #537
Conversation
Signed-off-by: Jake Massimo <[email protected]>
| ); | ||
|
|
||
| #define crypto_sign MLD_NAMESPACETOP | ||
| #define crypto_sign MLD_NAMESPACE(sign) |
There was a problem hiding this comment.
We will merge #532 that removes namespacetop, so won't have this issue on rebase.
Signed-off-by: Jake Massimo <[email protected]>
Signed-off-by: Jake Massimo <[email protected]>
| #include "../../mldsa/sign.h" | ||
| #define MLD_CONFIG_API_PARAMETER_SET MLD_CONFIG_PARAMETER_SET | ||
| #define MLD_CONFIG_API_NAMESPACE_PREFIX mldsa | ||
| #include "../../mldsa/mldsa_native.h" |
There was a problem hiding this comment.
let's change this to #include "mldsa_native/mldsa/mldsa_native.h and add the symlink mldsa_native.
Like in mlkem-native
| mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c | ||
| mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h | ||
| mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc | ||
| mldsa/mldsa_native.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h |
There was a problem hiding this comment.
liboqs does not actually need that file. Let's exclude it.
There was a problem hiding this comment.
@jakemas IIRC the plan was to have the monobuild files in the monobuild example folder first, and eventually restructure everything to follow the directory pattern as in mlkem-native (with mldsa/src/* for the bulk of the source, and mldsa/mldsa_native.* for the toplevel). I don't think we want mldsa_native.c in the toplevel directory.
Why is mldsa_native.c needed for this change at all, actually?
3 participants
When the file
mldsa-native.cis within the directorymldsa/we get issues with the Windows CI was failing with duplicate symbol errors because the NMAKE wildcard pattern{mldsa}.cwas including both individual source files AND the single compilation unitmldsa_native.c, causing conflicts. I movedmldsa-native.cup one directory to solve this, but we may instead want to switch over to the mlkem-nativesrc/style.Implemented:
Merging #532 first will clean up NAMESPACETOP issues, so should be done before this PR.
Testing CI, once scope and review is happy, I will remove fix ups, create a nice commit message etc.