Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BIBLIOGRAPHY.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ source code and documentation.
- [mldsa/config.h](mldsa/config.h)
- [mldsa/fips202/fips202.c](mldsa/fips202/fips202.c)
- [mldsa/fips202/fips202x4.c](mldsa/fips202/fips202x4.c)
- [mldsa/mldsa_native.h](mldsa/mldsa_native.h)
- [mldsa/ntt.h](mldsa/ntt.h)
- [mldsa/poly.c](mldsa/poly.c)
- [mldsa/polyvec.c](mldsa/polyvec.c)
Expand Down
3 changes: 1 addition & 2 deletions examples/basic/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ CFLAGS := \
-O3 \
$(CFLAGS)

# Use the default namespace prefix from config.h
# CFLAGS += -DMLD_CONFIG_NAMESPACE_PREFIX=mldsa
CFLAGS += -DMLD_CONFIG_NAMESPACE_PREFIX=mldsa

BINARY_NAME_FULL_44=$(BUILD_DIR)/$(BIN)44
BINARY_NAME_FULL_65=$(BUILD_DIR)/$(BIN)65
Expand Down
5 changes: 3 additions & 2 deletions examples/basic/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
* This requires specifying the parameter set and namespace prefix
* used for the build.
*/

#include "../../mldsa/sign.h"
#define MLD_CONFIG_API_PARAMETER_SET MLD_CONFIG_PARAMETER_SET
#define MLD_CONFIG_API_NAMESPACE_PREFIX mldsa
#include "../../mldsa/mldsa_native.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change this to #include "mldsa_native/mldsa/mldsa_native.h and add the symlink mldsa_native.
Like in mlkem-native

#include "expected_signatures.h"
#include "test_only_rng/notrandombytes.h"

Expand Down
23 changes: 12 additions & 11 deletions integration/liboqs/ML-DSA-44_META.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_c.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c
mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h
mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc
mldsa/mldsa_native.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liboqs does not actually need that file. Let's exclude it.

mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h
mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h
mldsa/zetas.inc
- name: x86_64
version: FIPS204
folder_name: .
Expand All @@ -43,10 +44,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_x86_64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
supported_platforms:
- architecture: x86_64
operating_systems:
Expand All @@ -66,10 +67,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_aarch64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
supported_platforms:
- architecture: arm_8
operating_systems:
Expand Down
23 changes: 12 additions & 11 deletions integration/liboqs/ML-DSA-65_META.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_c.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c
mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h
mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc
mldsa/mldsa_native.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h
mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h
mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h
mldsa/zetas.inc
- name: x86_64
version: FIPS204
folder_name: .
Expand All @@ -43,10 +44,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_x86_64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
supported_platforms:
- architecture: x86_64
operating_systems:
Expand All @@ -66,10 +67,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_aarch64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
supported_platforms:
- architecture: arm_8
operating_systems:
Expand Down
23 changes: 12 additions & 11 deletions integration/liboqs/ML-DSA-87_META.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_c.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c
mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h
mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc
mldsa/mldsa_native.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c mldsa/packing.h mldsa/params.h
mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h mldsa/randombytes.h
mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h mldsa/symmetric.h mldsa/sys.h
mldsa/zetas.inc
- name: x86_64
version: FIPS204
folder_name: .
Expand All @@ -43,10 +44,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_x86_64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/x86_64
supported_platforms:
- architecture: x86_64
operating_systems:
Expand All @@ -65,10 +66,10 @@ implementations:
api-with-context-string: true
sources: integration/liboqs/config_aarch64.h integration/liboqs/fips202_glue.h integration/liboqs/fips202x4_glue.h
mldsa/cbmc.h mldsa/common.h mldsa/ct.c mldsa/ct.h mldsa/debug.c mldsa/debug.h
mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h mldsa/packing.c
mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c mldsa/polyvec.h
mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c mldsa/sign.h
mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
mldsa/mldsa_native.h mldsa/native/api.h mldsa/native/meta.h mldsa/ntt.c mldsa/ntt.h
mldsa/packing.c mldsa/packing.h mldsa/params.h mldsa/poly.c mldsa/poly.h mldsa/polyvec.c
mldsa/polyvec.h mldsa/randombytes.h mldsa/reduce.h mldsa/rounding.h mldsa/sign.c
mldsa/sign.h mldsa/symmetric.h mldsa/sys.h mldsa/zetas.inc mldsa/native/aarch64
supported_platforms:
- architecture: arm_8
operating_systems:
Expand Down
Loading