handle wallet birthday height for non-mainnet chain ids

[TalDerei]

references #214

unblocks beta testers to receive test funds

[grod220]

I think I've realized that the core of the issue can be fixed be re-ordering the onboarding steps.

So instead of:

New seedphrase + birthday -> password -> rpc -> frontend -> numeraire

We can do:

rpc -> New seedphrase + birthday -> password -> frontend -> numeraire

That way, things downstream that require knowledge of the chain id don't have to assume mainnet. This prevents the need for us to have steps after to correct incorrect state.

Edit: In this case, we couldn't forget that we have to hold services init with the import-seed-phrase route completes the birthday step.

[grod220]

issue: This actually too late. The wallet birthday at this point has already been passed to the block processor. It will only pick up this change after the service worker resets.

[TalDerei]

this is a great catch. I was under the impression that block syncing started after the last onboarding step, but it actually begins after selecting the rpc endpoint. I revised the logic and migrated it into the grpc page.

[TalDerei]

I think I've realized that the core of the issue can be fixed be re-ordering the onboarding steps.

This is tricky. I've considered this, but separating the rpc and frontend steps doesn't feels natural to the onboarding flow in my opinion.

[grod220]

issue: unfortunately, I still think this is running after services has initialized. Sadly it looks like the useGrpcEndpointForm is incredibly complicated. It's an example of where useEffect() adds complexity... See:

• setGrpcEndpoint runs before onSuccess
• which means local storage being set first
• which means startWalletServices() proceeds through that line and starts services with the old walletCreationBlockHeight

[TalDerei]

tricky, maybe migrate the logic directly into onSubmit?

[TalDerei]

like why can't we reorder the operations inside the onSubmit async function?

        await setGrpcEndpoint(grpcEndpointInput);

        const storedParams = await localExtStorage.get('params');
        if (storedParams) {
          const parsedParams = JSON.parse(storedParams) as AppParameters;
          if (!parsedParams.chainId.includes('penumbra-1')) {
            await localExtStorage.set('walletCreationBlockHeight', 0);
          }
        }
        
        // block service init
        
        void chrome.runtime.sendMessage(ServicesMessage.ClearCache);
              
         ...

       await onSuccess();

to ensure a proper sequencing?

[TalDerei]

there must be a way to explicitly block on wallet service init until this code block completes.

[TalDerei]

or we can block wallet service init directly inside onboardGrpcEndpoint?

[TalDerei]

settled on fcd8e41 for simplicity and readability.

[TalDerei]

how can we test this with the beta chrome extension per penumbra-zone/web#1853? cc @VanishMax

[grod220]

how can we test this with the beta chrome extension

Whenever we want, we can publish to the prax staging env:

https://chromewebstore.google.com/detail/prax-wallet-beta/ejpfkiblcablembkdhcofhokccbbppnc?authuser=0&hl=en

We should probably create a github action that we can manually run to help us with this

[grod220]

Alternative suggestion for using a beforeSubmit hook: #220

[grod220]

Could you write a few unit tests for correctBirthdayHeightIfNeeded()?