-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle wallet birthday height for non-mainnet chain ids #216
base: main
Are you sure you want to change the base?
Changes from 1 commit
022c3a6
bc8a258
1333d03
de587be
fcd8e41
3476720
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: This actually too late. The wallet birthday at this point has already been passed to the block processor. It will only pick up this change after the service worker resets. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a great catch. I was under the impression that block syncing started after the last onboarding step, but it actually begins after selecting the rpc endpoint. I revised the logic and migrated it into the grpc page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: unfortunately, I still think this is running after services has initialized. Sadly it looks like the
useGrpcEndpointForm
is incredibly complicated. It's an example of where useEffect() adds complexity... See:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tricky, maybe migrate the logic directly into onSubmit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like why can't we reorder the operations inside the onSubmit async function?
to ensure a proper sequencing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there must be a way to explicitly block on wallet service init until this code block completes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we can block wallet service init directly inside onboardGrpcEndpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
settled on fcd8e41 for simplicity and readability.