Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new conventions on Turek Hron FSI3 case #130

Merged
merged 23 commits into from
Dec 17, 2020

Conversation

uekerman
Copy link
Member

This PR applies all main changes from @MakisH and my restructuring discussion on the FSI3 case. This case should serve as a role model to copy from when porting other cases.

Summary:

  • I deleted the alternatives OpenFOAM-CalculiX and OpenFOAM-FEniCS and only kept OpenFOAM-dealii. The purpose of the FSI3 case is to have one proper verification case, not to show flexibility of preCICE. So, it's enough to have only one version. OpenFOAM-FEniCS never made really sense here as the structure model in FEniCS is only linear. OpenFOAM-CCX is complicated to port as the CCX adapter currently doesn't support stresses as coupling data. We wanted to keep one tutorial with stresses, however.
  • The case is flattened.
  • Both solvers are called from the subdirectories, i.e. exchange-directory="..". Run and clean scripts adjusted (I kept the clean script for the moment).
  • Basic information is given in the README.
  • Consistent names: Stress and Displacement.

@MakisH Please have a detailed look at the README.
@davidscn Please try to run the case and please add a displacement plot of the actual case (with this exact mesh). You can directly push to my branch.

@uekerman uekerman self-assigned this Dec 14, 2020
@uekerman uekerman added this to In progress in Restructure Tutorials via automation Dec 14, 2020
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the binary file nonlinear_elasticity. We need it in the .gitingore.

I also added a few more comments.

Overall, I like it, it only needs a bit of polishing.

turek-hron-fsi3/README.md Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
@davidscn
Copy link
Member

Please try to run the case and please add a displacement plot of the actual case (with this exact mesh). You can directly push to my branch.

I guess you mean the most refined mesh on the Fluid side? Or rather the exact given mesh?

@davidscn
Copy link
Member

Another deal.II specific point: since we start the solver now from sub-directories, the log, result and parameter files are all in one directory. We should probably use a specific directory for the solution files.

@uekerman
Copy link
Member Author

Please try to run the case and please add a displacement plot of the actual case (with this exact mesh). You can directly push to my branch.

I guess you mean the most refined mesh on the Fluid side? Or rather the exact given mesh?

The results we show here should coincide with the mesh that we provide.
Which mesh do we currently provide? Compared to the results in the OpenFOAM adapter paper. The mesh should be fine enough to give good results (compute time is not an issue for this case).

@davidscn
Copy link
Member

Please try to run the case and please add a displacement plot of the actual case (with this exact mesh). You can directly push to my branch.

I guess you mean the most refined mesh on the Fluid side? Or rather the exact given mesh?

The results we show here should coincide with the mesh that we provide.
Which mesh do we currently provide? Compared to the results in the OpenFOAM adapter paper. The mesh should be fine enough to give good results (compute time is not an issue for this case).

We provide all meshes (refinement level one to three). The default mesh (20k cells) is the most coarse one, the most refined (45k cells) is called blockMesh_double_refined. If we just show a plot of the y displacement from 0 up to 15 sec, differences will probably only be noticeable in terms of the absolute time.

@uekerman
Copy link
Member Author

We provide all meshes (refinement level one to three).

Ah ok. I'll add a note in the README.

The default mesh (20k cells) is the most coarse one, the most refined (45k cells) is called blockMesh_double_refined. If we just show a plot of the y displacement from 0 up to 15 sec, differences will probably only be noticeable in terms of the absolute time.

Yes, let's keep the 20k as default and let's then add all picture generated from that one.

@davidscn
Copy link
Member

Perfect,
maybe also add a note for the mapping for the most refined case, where it is probably better to replace the global rbf by sth like:

        <mapping:rbf-compact-tps-c2 direction="read" from="Fluid-Mesh-Centers" to="Solid-Mesh" support-radius="0.011" constraint="consistent" />

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to improve. Other than that, looks very good!

turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Outdated Show resolved Hide resolved
turek-hron-fsi3/README.md Show resolved Hide resolved
turek-hron-fsi3/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants