feat: Add core services & navigation#1638
Open
bthebladeprimer wants to merge 2 commits into
Open
Conversation
8 tasks
Contributor
Generated by 🚫 Danger Swift against 04cf0f1 |
bthebladeprimer
force-pushed
the
bn/feature/cc-08-analytics-logging-a11y
branch
from
2945751 to
c1eb1bb
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-09-services-navigation
branch
from
6d57497 to
0a8b7bc
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-08-analytics-logging-a11y
branch
from
ef5c8c1 to
af0c77e
Compare
bthebladeprimer
force-pushed
the
bn/feature/cc-09-services-navigation
branch
from
d0e13e1 to
04cf0f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigurationServicefor fetching and caching checkout configurationErrorMessageResolverfor mapping validation errors to user-facing messagesCheckoutCoordinator,CheckoutNavigator,BackportedNavigationStack, andCheckoutRouteRawDataManagerProtocol,VaultManagerProtocol,AnalyticsSessionConfigProvidingCheckoutComponentsStringsconstants for localized string keysContext
PR 9 of 16 in the CheckoutComponents feature split. Depends on PR 8 (analytics, logging & accessibility).
Notion tracker
Test plan
ConfigurationServiceTests— verify config fetch, caching, and error handlingErrorMessageResolverTests/ErrorMessageResolverFieldErrorTests— verify error-to-message mappingCheckoutCoordinatorTests— verify route coordinationCheckoutNavigatorTests— verify navigation stack managementAnalyticsSessionConfigProviderTests— verify session config generation