-
-
Couldn't load subscription status.
- Fork 1.6k
pr05 Typescript Migration #16: Fix build error webpack example config #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr05 Typescript Migration #16: Fix build error webpack example config #3696
Conversation
c83a377 to
5d8f4fd
Compare
| rules: [ | ||
| { | ||
| test: /\.js$/, | ||
| test: /\.[jt]sx?$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main change to solve the issue, screenshot in description was taken after just this change
include tsx just in case?
I updated the rest of the babel-loader regex patterns to be this pattern to include tsx jsx just in case so it's a bit more flexible even if the fetching script is from the server. happy to revert if stricter is preferred @raclim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! This sounds good to me! If needed, we can follow up with any changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much again for following up on this, will get this in and take a look at the other PR!
Fixes #issue-number #3694
Changes:
webpack/config.examples.jsto match ts & tsx files (previously only js and jsx)Before:
After:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123