Skip to content

Conversation

@clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Oct 22, 2025

Fixes #issue-number #3694

Changes:

  • update regex in webpack/config.examples.js to match ts & tsx files (previously only js and jsx)

Before:

Screenshot 2025-10-22 at 14 38 02

After:

Screenshot 2025-10-22 at 14 38 23

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@clairep94 clairep94 force-pushed the fix_build_error_webpackExampleConfig branch from c83a377 to 5d8f4fd Compare October 22, 2025 13:46
rules: [
{
test: /\.js$/,
test: /\.[jt]sx?$/,
Copy link
Collaborator Author

@clairep94 clairep94 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change to solve the issue, screenshot in description was taken after just this change

include tsx just in case?

I updated the rest of the babel-loader regex patterns to be this pattern to include tsx jsx just in case so it's a bit more flexible even if the fetching script is from the server. happy to revert if stricter is preferred @raclim

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! This sounds good to me! If needed, we can follow up with any changes!

@clairep94 clairep94 changed the title Fix build error webpack example config pr05: Fix build error webpack example config Oct 24, 2025
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much again for following up on this, will get this in and take a look at the other PR!

@raclim raclim merged commit 89dd4b3 into processing:develop Oct 26, 2025
1 check passed
@clairep94 clairep94 changed the title pr05: Fix build error webpack example config pr05 Typescript Migration #16: Fix build error webpack example config Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr05 Grant Projects pr05 Grant Projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants