Skip to content

pr05 Typescript Migration #16: Fix build error webpack example config #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2025
+4 −4
Merged

pr05 Typescript Migration #16: Fix build error webpack example config #3696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1086f6
fix example config, previously not including ts files in regex
clairep94 Oct 22, 2025
f641212
npm i
clairep94 Oct 22, 2025
5d8f4fd
make regex more flexible for safety to include jsx,tsx files even on …
clairep94 Oct 22, 2025
46f5130
Merge branch 'develop' into fix_build_error_webpackExampleConfig
clairep94 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webpack/config.examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = [
module: {
rules: [
{
test: /\.js$/,
test: /\.[jt]sx?$/,
Copy link
Collaborator Author

@clairep94 clairep94 Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main change to solve the issue, screenshot in description was taken after just this change

include tsx just in case?

I updated the rest of the babel-loader regex patterns to be this pattern to include tsx jsx just in case so it's a bit more flexible even if the fetching script is from the server. happy to revert if stricter is preferred @raclim

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! This sounds good to me! If needed, we can follow up with any changes!

exclude: /node_modules/,
loader: 'babel-loader',
options: {
Expand Down Expand Up @@ -52,7 +52,7 @@ module.exports = [
module: {
rules: [
{
test: /\.[jt]s$/,
test: /\.[jt]sx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
options: {
Expand Down Expand Up @@ -82,7 +82,7 @@ module.exports = [
module: {
rules: [
{
test: /\.[jt]s$/,
test: /\.[jt]sx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
options: {
Expand Down
2 changes: 1 addition & 1 deletion webpack/config.server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module.exports = {
module: {
rules: [
{
test: /\.[jt]s$/,
test: /\.[jt]sx?$/,
exclude: /node_modules/,
loader: 'babel-loader',
options: {
Expand Down
Loading