Updating Gray-scale in colorMode() #7690
Conversation
src/color/setting.js
Outdated
| * <a href="#/p5.Color">p5.Color</a> objects remember the mode that they were | ||
| * created in. Changing modes doesn't affect their appearance. | ||
| * | ||
| * `Single-value (Grayscale) Colors` : |
There was a problem hiding this comment.
The colon in "Single-value (Grayscale) Colors :" has an extra space before it. small thing but wanted to check for concistency.
src/color/setting.js
Outdated
| * @example | ||
| * <div> | ||
| * <code> | ||
| * | ||
| * // Example: Single-value (Grayscale) colors in different color modes. | ||
| * // Each rectangle is filled with one parameter, but its final color depends | ||
| * // on how that parameter is interpreted by the current color mode. | ||
| * |
There was a problem hiding this comment.
Hi @limzykenneth can you look at this sketch? can we keep this one or should I change it?
There was a problem hiding this comment.
I'm thinking whether to include LAB and HWB instead of the other color spaces, as although LAB and HWB may potentially be the most confusing to work with and can benefit from examples, it may be counter productive to include it here because of the same reason with grayscale usage possibly something that people actively choosing LAB or HWB color space would not be aiming to do.
Eg. For Lab color space, LCH is much easier to use while the lightness value (L) works the same for both. While for HWB, the benefit is to be able to choose a hue and adjust its brightness and darkness with two separate handle like mixing color directly, as opposed to thinking about saturation then brightness/lightness which can be less intuitive, as such it can be reasoned that grayscale for HWB is more of an edge case.
|
Hi @limzykenneth I removed Lab and hwb, let me know if still there's any changes required. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/color/setting.js:793
- There is a missing space between 'the' and the backtick before 'whiteness (W)'. Please add a space for clarity.
* * - `HWB`: Grayscale relies on both the` whiteness (W)` and `blackness (B)` channels.
No description provided.