-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Updating Gray-scale in colorMode() #7690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @limzykenneth can you look at this sketch? can we keep this one or should I change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking whether to include LAB and HWB instead of the other color spaces, as although LAB and HWB may potentially be the most confusing to work with and can benefit from examples, it may be counter productive to include it here because of the same reason with grayscale usage possibly something that people actively choosing LAB or HWB color space would not be aiming to do.
Eg. For Lab color space, LCH is much easier to use while the lightness value (L) works the same for both. While for HWB, the benefit is to be able to choose a hue and adjust its brightness and darkness with two separate handle like mixing color directly, as opposed to thinking about saturation then brightness/lightness which can be less intuitive, as such it can be reasoned that grayscale for HWB is more of an edge case.