OpenThread: ClearAllSrpHostAndServices should be guarded with CHIP_DE… #36284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
|
Review changes with SemanticDiff. |
|
PR #36284: Size comparison from c18a6de to 3e4a1e9 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
wqx6
approved these changes
Oct 30, 2024
dhrishi
approved these changes
Oct 30, 2024
jmartinez-silabs
approved these changes
Oct 30, 2024
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Oct 30, 2024
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284) The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Oct 30, 2024
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284) The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Nov 11, 2024
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284) The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284) The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jan 16, 2025
…ed with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT (project-chip#36284) (project-chip#36296) The code block added in project-chip#35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation. (cherry picked from commit ce0101d) Signed-off-by: Adrian Gielniewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…VICE_CONFIG_ENABLE_THREAD_SRP_CLIENT
The code block added in #35065 should be guarded, if the thread stack manager is not pulled in then this function is not available and breaks the compilation.