Skip to content

OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT. #38241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 2 commits into from
Apr 3, 2025
Merged

OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT. #38241

mergify merged 2 commits into from
Apr 3, 2025

Conversation

@shripad621git
Copy link
Contributor

@shripad621git shripad621git commented Apr 3, 2025 •
edited
Loading

Problem

Change Overview

  • Added the guard for ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT.
  • Added the thread-br-app esp32 in CI testing for esp32s3 target.

Testing

  • Tested the thread br app esp32 for resolution of compilation failure post the changes.
  • Steps:
cd /path/to/examples/thread-br-app/esp32
idf.py set target esp32s3
idf.py build

@shripad621git shripad621git changed the title OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_SRP_CLIENT. OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT. Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

PR #38241: Size comparison from 86e1daf to a74f777

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 86e1daf a74f777 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098486 1098486 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653410 653410 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830666 830666 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063170 1063170 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 893972 893972 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976848 976848 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818652 818652 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827572 827572 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774432 774432 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758692 758692 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542006 542006 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576106 576106 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660221 660221 0 0.0
RAM 75428 75428 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680081 680081 0 0.0
RAM 78068 78068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680081 680081 0 0.0
RAM 78068 78068 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637013 637013 0 0.0
RAM 70496 70496 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620517 620517 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640161 640161 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640161 640161 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639973 639973 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659689 659689 0 0.0
RAM 77220 77220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659689 659689 0 0.0
RAM 77220 77220 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616313 616313 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636173 636173 0 0.0
RAM 71404 71404 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636173 636173 0 0.0
RAM 71404 71404 0 0.0
efr32 lock-app BRD4187C FLASH 941200 941200 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735128 735128 0 0.0
RAM 234852 234852 0 0.0
window-app BRD4187C FLASH 1033472 1033472 0 0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103376 103376 0 0.0
FLASH 1785582 1785582 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121948 121948 0 0.0
FLASH 1752102 1752102 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2720553 2720553 0 0.0
RAM 114184 114184 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6191868 6191868 0 0.0
RAM 531208 531208 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5376504 5376504 0 0.0
RAM 224432 224432 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4689438 4689438 0 0.0
RAM 202816 202816 0 0.0
camera-app debug unknown 8720 8720 0 0.0
FLASH 6532651 6532651 0 0.0
RAM 222040 222040 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13716843 13716843 0 0.0
RAM 645928 645928 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14103379 14103379 0 0.0
RAM 635984 635984 0 0.0
chip-tool-ipv6only arm64 unknown 22872 22872 0 0.0
FLASH 12187192 12187192 0 0.0
RAM 688624 688624 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12249747 12249747 0 0.0
RAM 635376 635376 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4521294 4521294 0 0.0
RAM 190112 190112 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5659093 5659093 0 0.0
RAM 486216 486216 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5584865 5584865 0 0.0
RAM 207064 207064 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4757170 4757170 0 0.0
RAM 194208 194208 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4379202 4379202 0 0.0
RAM 182928 182928 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4509566 4509566 0 0.0
RAM 187400 187400 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3005868 3005868 0 0.0
RAM 147456 147456 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4197892 4197892 0 0.0
RAM 231912 231912 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 5996997 5996997 0 0.0
RAM 609632 609632 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12264237 12264237 0 0.0
RAM 754256 754256 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916424 916424 0 0.0
RAM 167443 167443 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909048 909048 0 0.0
RAM 145687 145687 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852848 852848 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 588656 588656 0 0.0
RAM 70996 70996 0 0.0
mcxw71+release FLASH 607200 607200 0 0.0
RAM 63272 63272 0 0.0
light k32w0+release FLASH 614476 614476 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 691496 691496 0 0.0
RAM 72128 72128 0 0.0
lock mcxw71+release FLASH 756960 756960 0 0.0
RAM 67684 67684 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661660 1661660 0 0.0
RAM 212328 212328 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565636 1565636 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442540 1442540 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471428 1471428 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665244 665244 0 0.0
RAM 105172 105172 0 0.0
lock-app qpg6105+debug FLASH 623712 623712 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 461216 461216 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 689198 689198 0 0.0
RAM 101852 101852 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777236 777236 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 767498 767498 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 783872 755958 -27914 -3.6
RAM 109308 97540 -11768 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 705170 683058 -22112 -3.1
RAM 62620 51588 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741352 711508 -29844 -4.0
RAM 85808 73408 -12400 -14.5
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709054 709054 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603092 603092 0 0.0
RAM 148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 818478 818482 4 0.0
RAM 107568 107568 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1784344 1784344 0 0.0
RAM 94280 94280 0 0.0
chip-tool-ubsan arm unknown 11864 11864 0 0.0
FLASH 20110286 20110286 0 0.0
RAM 8811352 8811352 0 0.0

@mergify mergify bot merged commit 841af0c into project-chip:master Apr 3, 2025
76 checks passed
soares-sergio pushed a commit to soares-sergio/connectedhomeip that referenced this pull request Apr 8, 2025
@shripad621git @soares-sergio
OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_…
9b3a943 
…ENABLE_THREAD_SRP_CLIENT. (project-chip#38241)

* OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT

* .github/workflows: Added the thread-br-app in the CI tests for esp32s3 target
sayondeep pushed a commit to sayondeep/connectedhomeip that referenced this pull request Apr 10, 2025
@shripad621git
OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_…
1f88317 
…ENABLE_THREAD_SRP_CLIENT. (project-chip#38241)

* OpenThread: Guard ClearAllSrpHostAndServices with CHIP_DEVICE_CONFIG_ENABLE_THREAD_SRP_CLIENT

* .github/workflows: Added the thread-br-app in the CI tests for esp32s3 target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

@shubhamdp shubhamdp shubhamdp approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees

No one assigned

Labels

github platform review - approved workflows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shripad621git @andy31415 @shubhamdp @jmartinez-silabs